Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 geojson extract #137

Merged
merged 9 commits into from
Mar 7, 2024
Merged

32 geojson extract #137

merged 9 commits into from
Mar 7, 2024

Conversation

volcan01010
Copy link
Collaborator

@volcan01010 volcan01010 commented Mar 6, 2024

Summary

This merge request adds backend functions that can be used in an /extract_geojson endpoint.

The extract_geojson function accepts a file Path and returns a dictionary representation of the GeoJSON FeatureCollection, raising a ValueError if there is a problem with the file. The concatenate_feature_collections function accepts a list of GeoJSON FeatureCollections and merges the features. It can be used where users have uploaded multiple files.

To test

  • Confirm that tests pass

@volcan01010 volcan01010 requested a review from ximenesuk March 6, 2024 18:02
@volcan01010
Copy link
Collaborator Author

This merge request adds backend functions that can be used in an /extract_geojson endpoint.

Having said this, just calling the functions at the end of the validation process and including the results in the returned JSON saves the users having to upload the files twice and is probably the least-effort way to include the GeoJSON in any result.

I hadn't really thought about the extra effort in having to upload the files again for a separate endpoint.

@ximenesuk ximenesuk force-pushed the 32-geojson-extract branch from a8cac8f to 66bc41e Compare March 7, 2024 10:40
@ximenesuk ximenesuk merged commit 4ba8e73 into main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants