Skip to content

Commit

Permalink
Remove exit-zero on flake8
Browse files Browse the repository at this point in the history
  • Loading branch information
KoalaGeo committed Apr 25, 2023
1 parent 32281d5 commit 839a417
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/lint_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ jobs:
- name: Lint app/ with flake8
run: |
# exit-zero treats all errors as warnings.
flake8 app/ --exit-zero

This comment has been minimized.

Copy link
@ximenesuk

ximenesuk Apr 25, 2023

Collaborator

You should be able to combine these two uses of flake8:

flake8 app/ test/

This comment has been minimized.

Copy link
@ximenesuk

ximenesuk Apr 25, 2023

Collaborator

Though maybe next time there is a branch to merge!

flake8 app/
- name: Lint test/ with flake8
run: |
# exit-zero treats all errors as warnings.
flake8 test/ --exit-zero
flake8 test/
- name: Test with pytest
run: |
Expand Down
2 changes: 1 addition & 1 deletion app/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def custom_openapi():
license_info={
"name": "Open Government Licence v3",
"url": "https://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/",
},
},
routes=app.routes,
)
openapi_schema["info"]["x-logo"] = {
Expand Down

0 comments on commit 839a417

Please sign in to comment.