Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

215 make oracledbhelperget sqlalchemy connection string use oracle+oracledb instead of oracle #217

Merged
merged 2 commits into from
Nov 26, 2024
Merged

215 make oracledbhelperget sqlalchemy connection string use oracle+oracledb instead of oracle #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4df22f6
Use 'oracle+oracledb://'
leorudczenko Nov 26, 2024
6ac4ecd
Apply change to test
leorudczenko Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etlhelper/db_helpers/oracle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@ def get_sqlalchemy_connection_string(self, db_params, password_variable):
Returns connection string for SQLAlchemy engine.
"""
password = self.get_password(password_variable)
return (f'oracle://{db_params.user}:{password}@'
return (f'oracle+oracledb://{db_params.user}:{password}@'
f'{db_params.host}:{db_params.port}/{db_params.dbname}')
2 changes: 1 addition & 1 deletion test/unit/test_db_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def test_connect(monkeypatch, db_params, driver, expected):


@pytest.mark.parametrize('db_params, expected', [
(ORACLEDB, 'oracle://testuser:mypassword@server:1521/testdb'),
(ORACLEDB, 'oracle+oracledb://testuser:mypassword@server:1521/testdb'),
(MSSQLDB,
'mssql+pyodbc://testuser:mypassword@server:1521/testdb?driver=test+driver'),
# NOQA
Expand Down