Support for AddCaptioning #36
Conversation
|
|
||
| public BrightcoveCaptioning AddCaptioning(string captionFileUrl, string videoReferenceId, string filename) | ||
| { | ||
| return DoAddCaptioningWithExternalUrl(captionFileUrl, -1, videoReferenceId, filename); |
There was a problem hiding this comment.
Do we need both of these methods? I don't think we gonna use videoReferenceId
There was a problem hiding this comment.
@kish9nine told me we will only be using videoId, but I added them both to comply with existing conventions
|
Sorry guys, didn't realize it's the main repo and was commenting in context of our fork. |
|
Hey guys, this is fantastic! I love seeing contributions back from the community :-D Unfortunately, I'm not really set up to work on .NET code these days. I originally wrote this wrapper 2 jobs and over 4 years ago, and have been occassionally maintaining it in in my spare time, pulling in new contributions every once in a while. As you might be able to tell from the other open 6-month-old pull request that I've let languish, my spare time is in short supply these days. I'm going to ping my friends and former colleagues at Velir to ask if anyone there wants to take over maintenance of this project, since the copyright technically belongs to them. If not Velir, then I'm willing to bet that someone at Brightcove would step up to the plate. Thanks, and stay tuned. |
|
FYI, I reached out to Velir, but no one there has expressed interest in taking over the project. I emailed Brightcove this morning, and they're going ask around to see if anyone might want to take over maintenance. The thought occurs to me, though: as active users of the project, would you possibly be interested in being added to the project as collaborators? That way you could merge whatever changes you desire and issue official releases. |
|
Oops, this is still the same dmillz, I'm just logged in under my work account :-) |
|
Sure, I'm up for updating it (and probably writing another wrapper for their other API, their ingestion engine) |
|
Fantastic! I don't think I actually have permission on this repo to add collaborators, but I'll ask Brightcove to add you. Should we add @denmarkin too? |
* Added Sample DFXP file to resources * Addied Captioning Entity (it's the return type for AddCaptioning method) * Added Missing Mappings
amhed
force-pushed
the
feature/addCaptioning
branch
from
e3a43b7 to
71ea3b7
Compare
Hey guys,
We've been using the API and found that the
add_captioningmethod was missing from the wrapper, so we added it according to https://docs.brightcove.com/en/video-cloud/media/references/reference.html#Video_WriteThanks again!