Skip to content

Commit

Permalink
huge refactors+speed improvements+schedule fix
Browse files Browse the repository at this point in the history
  • Loading branch information
BrightDV committed Jan 4, 2024
1 parent 78acfa8 commit 7a52e9f
Show file tree
Hide file tree
Showing 19 changed files with 526 additions and 568 deletions.
2 changes: 1 addition & 1 deletion lib/Screens/FormulaYou/home.dart
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class _PersonalizedHomeScreenState extends State<PersonalizedHomeScreen> {
backgroundColor: useDarkMode
? Theme.of(context).scaffoldBackgroundColor
: Colors.white,
body: NewsFeedWidget(
body: NewsFeed(
tagId: selectedTagsIds.join(','),
),
);
Expand Down
4 changes: 2 additions & 2 deletions lib/Screens/article.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import 'package:boxbox/api/article_parts.dart';
import 'package:boxbox/api/news.dart';
import 'package:boxbox/api/formula1.dart';
import 'package:boxbox/helpers/loading_indicator_util.dart';
import 'package:boxbox/helpers/request_error.dart';
import 'package:flutter/material.dart';
Expand Down Expand Up @@ -117,7 +117,7 @@ class _ArticleScreenState extends State<ArticleScreen> {
class ArticleProvider extends StatelessWidget {
Future<Article> getArticleData(
String articleId, Function updateArticleTitle) async {
Article article = await F1NewsFetcher().getArticleData(articleId);
Article article = await Formula1().getArticleData(articleId);
updateArticleTitle(article.articleName);
return article;
}
Expand Down
13 changes: 4 additions & 9 deletions lib/Screens/circuit.dart
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@ import 'package:boxbox/Screens/article.dart';
import 'package:boxbox/Screens/race_details.dart';
import 'package:boxbox/api/ergast.dart';
import 'package:boxbox/api/event_tracker.dart';
import 'package:boxbox/api/news.dart';
import 'package:boxbox/api/formula1.dart';
import 'package:boxbox/api/race_components.dart';
import 'package:boxbox/helpers/convert_ergast_and_formula_one.dart';
import 'package:boxbox/helpers/loading_indicator_util.dart';
import 'package:boxbox/helpers/news.dart';
import 'package:boxbox/helpers/racetracks_url.dart';
import 'package:boxbox/helpers/request_error.dart';
import 'package:boxbox/Screens/circuit_map_screen.dart';
Expand All @@ -38,7 +39,7 @@ import 'package:flutter_markdown/flutter_markdown.dart';
import 'package:hive_flutter/hive_flutter.dart';
import 'package:url_launcher/url_launcher.dart';

class CircuitScreen extends StatefulWidget {
class CircuitScreen extends StatelessWidget {
final Race race;
final bool? isFetched;

Expand All @@ -48,14 +49,8 @@ class CircuitScreen extends StatefulWidget {
this.isFetched,
}) : super(key: key);

@override
State<CircuitScreen> createState() => _CircuitScreenState();
}

class _CircuitScreenState extends State<CircuitScreen> {
@override
Widget build(BuildContext context) {
final Race race = widget.race;
bool useDarkMode =
Hive.box('settings').get('darkMode', defaultValue: true) as bool;
bool useDataSaverMode = Hive.box('settings')
Expand All @@ -64,7 +59,7 @@ class _CircuitScreenState extends State<CircuitScreen> {
backgroundColor: useDarkMode
? Theme.of(context).scaffoldBackgroundColor
: Colors.white,
body: widget.isFetched ?? true
body: isFetched ?? true
? NestedScrollView(
headerSliverBuilder:
(BuildContext context, bool innerBoxIsScrolled) {
Expand Down
18 changes: 7 additions & 11 deletions lib/Screens/driver_details.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@
import 'package:boxbox/Screens/race_details.dart';
import 'package:boxbox/api/driver_components.dart';
import 'package:boxbox/api/ergast.dart';
import 'package:boxbox/api/news.dart';
import 'package:boxbox/api/formula1.dart';
import 'package:boxbox/helpers/convert_ergast_and_formula_one.dart';
import 'package:boxbox/helpers/custom_physics.dart';
import 'package:boxbox/helpers/driver_result_item.dart';
import 'package:boxbox/helpers/news.dart';
import 'package:boxbox/scraping/formula_one.dart';
import 'package:carousel_slider/carousel_slider.dart';
import 'package:flutter/foundation.dart';
Expand All @@ -34,7 +35,7 @@ import 'package:boxbox/helpers/driver_image.dart';
import 'package:boxbox/helpers/loading_indicator_util.dart';
import 'package:boxbox/helpers/request_error.dart';

class DriverDetailsScreen extends StatefulWidget {
class DriverDetailsScreen extends StatelessWidget {
final String driverId;
final String givenName;
final String familyName;
Expand All @@ -45,11 +46,6 @@ class DriverDetailsScreen extends StatefulWidget {
super.key,
});

@override
State<DriverDetailsScreen> createState() => _DriverDetailsScreenState();
}

class _DriverDetailsScreenState extends State<DriverDetailsScreen> {
@override
Widget build(BuildContext context) {
bool useDarkMode =
Expand All @@ -59,7 +55,7 @@ class _DriverDetailsScreenState extends State<DriverDetailsScreen> {
child: Scaffold(
appBar: AppBar(
title: Text(
'${widget.givenName} ${widget.familyName.toUpperCase()}',
'${givenName} ${familyName.toUpperCase()}',
style: const TextStyle(
fontWeight: FontWeight.w600,
),
Expand Down Expand Up @@ -91,8 +87,8 @@ class _DriverDetailsScreenState extends State<DriverDetailsScreen> {
: Colors.white,
body: TabBarView(
children: [
DriverInfo(widget.driverId),
DriverResults(widget.driverId),
DriverInfo(driverId),
DriverResults(driverId),
],
),
),
Expand Down Expand Up @@ -404,7 +400,7 @@ class DriverDetailsFragment extends StatelessWidget {
),
itemCount: driverDetails[1].length,
itemBuilder: (context, index) => FutureBuilder<Article>(
future: F1NewsFetcher().getArticleData(
future: Formula1().getArticleData(
driverDetails[1][index][0],
),
builder: (context, snapshot) {
Expand Down
Loading

0 comments on commit 7a52e9f

Please sign in to comment.