Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the make file #864

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

Joel-C-Johnson
Copy link
Contributor

@Joel-C-Johnson Joel-C-Johnson commented Aug 29, 2024

This PR is connected to the issue - 845

  • Understand the codebase
  • updated the code
  • Locally tested my running the makefile

image

image

@Joel-C-Johnson Joel-C-Johnson self-assigned this Aug 30, 2024
@Joel-C-Johnson Joel-C-Johnson added SP18 bug Something isn't working and removed bug Something isn't working labels Aug 30, 2024
@RevantCI
Copy link
Contributor

RevantCI commented Aug 30, 2024

The Make file currently only has the landing page and not the microservices.
This is from the time when it was a monolith architecture.
Currently all the micro services are deployed using docker compose staging and production use the docker hub images of the micro services.
This docker compose is easily deploy able and just needs docker to run.
As per my understanding the make file currently is not serving any of the micro services as documented by Joel Johnson, it can be removed after discussion with Joel Mathew and Kavitha.

@RevantCI RevantCI merged commit fb38c5c into Bridgeconn:version-2 Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants