Fix IndexError in add_definitions by checking list length
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjcantrell
commented
Dec 19, 2023
|
|
||
| # add definitions, citations to the graph | ||
| for definition in dictionary: | ||
| term = URIRef(definition[0]) | ||
| if len(definition) > len(header): |
There was a problem hiding this comment.
It appears some row's definitions are not wrapped in parentheses and using commas within the definition, which is causing parsing issues. This new condition should catch most of them.
There was a problem hiding this comment.
There was one bad row which you can fix in definitions.csv (I think it is the Tablet row)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified and fixed a test failure caused by an
IndexErrorduring the graph population process involving the 'seeAlso' definition. Additionally, to resolveflake8formatting conflicts with certain SPARQL queries and warning messages, I've implemented# noqacomments to selectively bypass these specific checks.