Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeling VRFs and Heat Pumps #590

Merged
merged 34 commits into from
Jan 15, 2024
Merged

Modeling VRFs and Heat Pumps #590

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
80edee0
Merge pull request #4 from BrickSchema/master
jbkoh Sep 20, 2023
36e645b
Merge pull request #5 from mapped/sync-with-upstream-230928
connorjcantrell Sep 28, 2023
dfe0985
Merge remote-tracking branch 'upstream/master'
connorjcantrell Nov 14, 2023
4d42a16
Merge pull request #6 from mapped/sync-with-upstream-231114
connorjcantrell Nov 14, 2023
b9cccb8
Merge branch 'master' of https://github.com/BrickSchema/Brick into up…
connorjcantrell Dec 5, 2023
f66670a
Merge pull request #7 from mapped/update-master
connorjcantrell Dec 5, 2023
a74f788
Add VRF, Heat Pump, and Chiller equipment
connorjcantrell Dec 5, 2023
256aec5
Add VRF System
connorjcantrell Dec 8, 2023
b6decd3
Add definitions
connorjcantrell Dec 12, 2023
8fc21e8
Add Condensing Unit definitions
connorjcantrell Dec 12, 2023
6f4cb1b
Add commas
connorjcantrell Dec 12, 2023
7eb9bd6
Add Expansion Valves
connorjcantrell Dec 12, 2023
4c5e4d5
Update Electronic Expansion Valve name
connorjcantrell Dec 12, 2023
2c8a2a2
Move expansion valves to new metering device class
connorjcantrell Dec 12, 2023
1e1fe92
Add refrigeration system
connorjcantrell Dec 12, 2023
3afe698
Add metering device definitions
connorjcantrell Dec 12, 2023
5a10c2c
Add connectedTo relationship
connorjcantrell Dec 12, 2023
8e73f53
Rename metering device to throttling device
connorjcantrell Dec 13, 2023
cbcc5d4
Add ground, air, water source condensing and packaged units
connorjcantrell Dec 13, 2023
192c141
Add alias to Duct FCU
connorjcantrell Dec 13, 2023
135c7c2
Add horizontal tag to Duct FCU
connorjcantrell Dec 13, 2023
c3d3f22
Rename throttling device to refrigerant metering device
connorjcantrell Dec 13, 2023
56f6ad1
Add capillary tube metering device
connorjcantrell Dec 13, 2023
fcfa489
Add VRF, Heat Pump, and Chiller equipment
connorjcantrell Dec 5, 2023
636e03e
Add Expansion Valves
connorjcantrell Dec 12, 2023
f313094
Update Electronic Expansion Valve name
connorjcantrell Dec 12, 2023
d15d70e
Move expansion valves to new metering device class
connorjcantrell Dec 12, 2023
720b806
Rename metering device to throttling device
connorjcantrell Dec 13, 2023
bbe898a
Merge branch 'master' into add-vrf
connorjcantrell Jan 12, 2024
c2950c4
Remove comma
connorjcantrell Jan 12, 2024
f1a83a6
Fix format
connorjcantrell Jan 12, 2024
bc0c789
Wrap definition
connorjcantrell Jan 12, 2024
6a03d2a
Update obsolete terms
connorjcantrell Jan 12, 2024
8510dd9
Remove Packaged GSHP
connorjcantrell Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bricksrc/relationships.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
Defining Brick relationships
"""
relationships = {
"connectedTo": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtfierro Is it necessary to specify that 'connectedTo' is a superclass to 'feeds' and 'isFedBy'?

Something like:

rdfs:subPropertyOf :feeds, :isFedBy ;

Copy link
Member

@gtfierro gtfierro Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my intended design, feeds and isFedBy would both be subproperties of connectedTo, thinking about it more. I'm not sure this is what we actually want to do. If we were to follow this design, then any use of the feeds relationship would also imply the existence of a connectedTo relationship.

This raises the essential question, which is "does connectedTo communicate a bidirectional relationship, or a relationship where the directionality is not known?" If its the former, then connectedTo should be a sibling of feeds and isFedBy because it is altogether different. If its the latter, then connectedTo should be a superproperty of feeds and isFedBy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does connectedTo communicate a bidirectional relationship, or a relationship where the directionality is not known?

I intended to use connectedTo to imply a bidirectional relationship. However, considering your point, 'connectedTo' doesn't explicitly convey directionality.

Alternatively, what about FeedsAndFedBy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want both:

  • "feedsAndFedBy" (we need a better name) for bidirectional. We want this to work for equipment as well as for spaces/locations
  • "connectedTo" for a super property of feeds, isFedby, and feedsAndFedBy that means "we don't know the direction"

A: [OWL.ObjectProperty, OWL.SymmetricProperty, OWL.IrreflexivProperty],
RDFS.label: Literal("Connected To"),
},
"isReplacedBy": {
A: [OWL.ObjectProperty, OWL.AsymmetricProperty, OWL.IrreflexiveProperty],
RDFS.label: Literal("Is replaced by"),
Expand Down
Loading