-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional ontology imports #501
Conversation
@hammar I'm trying to import the RealEstateCore ontology into the Brick repo so that we have integration tests against it. One issue I'm running into is that REC requires that all assets have an associated location. We have tried to put these constraints into model-level shape graphs (e.g. "for the Brick model for building ABC, there should be 20 VAVs and all should have an associated HVAC zone...", etc) rather than the schema itself. I understand if there is some reluctance to relax or lift this shape requirement, but can I ask how you have handled adding a location to all of your assets? Do you just add assets to the Building entity directly? Thanks! |
This hasn't been a concern that's been raised on our issues or to our TC prior to now, so I'm not sure how common (or not) it would be among our users to not have that spatial knowledge re. their assets' placements. My guess (but it really is just that) is that they would connect assets directly to the Building as you propose. |
It would be great if we could relax this requirement in order to reduce the modeling burden for folks who aren't trying to model everything in their building (we've been talking to folks that start with just a meter + equipment and don't really touch any of the spatial elements of the building). I've raised the question on the Matrix/gitter(?) channel |
There are some concepts deprecated in the
@epaulson were there any others you noticed? I'm clicking through the rdf-explorer interface. Latest Brick + the REC imports and patches can be found here: https://gist.github.com/gtfierro/a0556f7e5515cb3298df9459b033a8e4 |
There were some relationships that we hadn't settled - I think we were going to go with rec for hasPart but i think the REC patch also deprecated brick:feeds/isFedBy and maybe some other things. I'm not sure wha the right approach here is, having both just makes life hard for folks trying to query, but having a mix is equally confusing - "it's rec for hasPart and brick for feeds" is hard to explain to people why they're different and for folks to remember which relationship is in which namespace. |
We are still discussing with the REC team about how to handle the Brick and REC |
Adds ref-schema import (was not included by mistake) and latest RealEstateCore ontology
brickpatches
into Brick itselfrec:value
vsbrick:value
,rec:ElectricChargeObservation
, etc)recimports.ttl
(this should be fully covered by Brick's QUDT import)