-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Move output command state out of CliContext #426
Conversation
0bd3221
to
17bfa7d
Compare
To simplify things, all output commands can be treated similarily as they all act on the result of the processing pipeline. This allows new commands to be added without needing to explicitly define their values in CliContext, and makes the values that do remain there much more meaningful. It also allows commands to be specified multiple times gracefully and with different options, so for example `save-images` can now be run twice with different encoding parameters.
17bfa7d
to
ded3708
Compare
85d69f7
to
1154c01
Compare
Alright, I have had a good look through this and I think I have wrapped my head around it. I don't use the cli too often, so I always need to refresh my memory on how it all works. If I understand what this is doing correctly, then it works like this under this paradigm:
I think this makes sense and does make it easier to add additional output formats in the future. To add a new output format, I think the changes that would need to be made would be:
|
Though still WIP, feel free to check out #427 for a concrete example of how this simplifies adding new CLI commands. |
This PR makes it a lot easier to integrate new output commands into the CLI. The goal is to have the controller treat all output commands the same by operating on the result of the processing pipeline. For dependent jobs, they can still use the shared context to communicate results. This has a few benefits:
split-video
twice to generate output videos with different parameters--verbosity debug
This should also help reduce the friction to adding new output formats, supporting #156, #323, and #388. As part of this change, some log statements will now be emitted later when a command is actually running. Previously, some commands would emit things like the location of saved files when processing the command-line arguments, rather than when the sub-command was about to run.