refactor(Card): replace setReps()

BrayanDSO · Mar 24, 2024 · f889fcd · f889fcd
1 parent f9b2933
commit f889fcd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/AnkiDroid/src/main/java/com/ichi2/libanki/Card.kt b/AnkiDroid/src/main/java/com/ichi2/libanki/Card.kt
@@ -84,8 +84,9 @@ open class Card : Cloneable {
     var due: Int = 0
     var ivl = 0
     var factor = 0
+
+    @set:VisibleForTesting
     var reps = 0
-        private set
     var lapses = 0
     var left = 0
     var oDue: Int = 0
@@ -270,11 +271,6 @@ open class Card : Cloneable {
         timerStarted = TimeManager.time.intTimeMS() - elapsedTime
     }
 
-    @VisibleForTesting
-    fun setReps(reps: Int): Int {
-        return reps.also { this.reps = it }
-    }
-
     @LibAnkiAlias("should_show_timer")
     fun shouldShowTimer(col: Collection): Boolean {
         val options = col.decks.configDictForDeckId(currentDeckId().did)

diff --git a/AnkiDroid/src/test/java/com/ichi2/libanki/SchedulerTest.kt b/AnkiDroid/src/test/java/com/ichi2/libanki/SchedulerTest.kt
@@ -448,7 +448,7 @@ open class SchedulerTest : JvmTest() {
             queue = QUEUE_TYPE_REV
             due = (col.sched.today - 8)
             factor = STARTING_FACTOR
-            setReps(3)
+            reps = 3
             lapses = 1
             ivl = 100
         }
@@ -523,7 +523,7 @@ open class SchedulerTest : JvmTest() {
             type = CARD_TYPE_REV
             queue = QUEUE_TYPE_REV
             due = col.sched.today
-            setReps(1)
+            reps = 1
             ivl = 1
             startTimer()
         }
@@ -1266,7 +1266,7 @@ open class SchedulerTest : JvmTest() {
             queue = QUEUE_TYPE_REV
             due = 0
             factor = STARTING_FACTOR
-            setReps(3)
+            reps = 3
             lapses = 1
             ivl = 100
             startTimer()
@@ -1289,7 +1289,7 @@ open class SchedulerTest : JvmTest() {
             ivl = 100
             due = (col.sched.today - ivl)
             factor = STARTING_FACTOR
-            setReps(3)
+            reps = 3
             lapses = 1
             startTimer()
         }