Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fulfill the following Trello requirements:
API Working Screentshot (from Swagger UI):
Tests - JUnit and Maven:
Notes:
-Did not add a full set of validation for the incoming user id, but at least had a check for blank. This could be improved.
-There seemed to be a defect in the ResourceMapper, it would pump out the last five characters of a credit card, I switched it to four and added a test for that. (Unless I am misunderstanding the data.)
-Added test data to the sql test file.
-Ran the IntelliJ remove imports/reformat -- but did not run format on exiting updated files just new.
-Also fixed what quality complaints IntelliJ had.
-Confirmed the maven and the IDE build steps, as this can be an issue on some code bases but not this.
-The requirements said "#3 Payment Retrieve API should return all data for a given User." I made the assumption this was just payment data for a user and not user + payment data all in one shot. If this isn't what was expected I'd probably make a composition type object to accomplish this with the code, i.e.
UserPaymentsDto{
UserDto user;
List payments;
}
but canonically payment seems to imply payment only.