feat(push-image): use execFilerSync instead of docker-cli-js to execute docker #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josa42
force-pushed
the
josa42/replace-docker-cli-js
branch
from
9d0aa91
to
c3d1bc2
Compare
josa42
commented
Jan 4, 2024
| @@ -40,5 +40,5 @@ outputs: | |||
| imageDigest: | |||
| description: The image digest of the Docker image. Can be used to request a deployment. | |||
| runs: | |||
| using: node16 | |||
| using: node20 | |||
josa42
commented
Jan 4, 2024
|
|
||
| const { execFileSync } = require('child_process'); | ||
|
|
||
| function docker(command, ...args) { |
There was a problem hiding this comment.
This function basically replaces docker-cli-js
josa42
force-pushed
the
josa42/replace-docker-cli-js
branch
from
c3d1bc2
to
d7c784a
Compare
lukewhiting
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve the issues which surfaced when switching to custom github action runners:
Unfortunately I cannot say why, but replacing the docker-cli-js package by executing docker via child_process.execFileSync and updating the action to node 20 solved the issue.
See: https://github.com/brandwatch/frontend-apps/actions/runs/7409414270/job/20160283262