Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade CRoaring to v2.0.2 #1

Merged
merged 6 commits into from
Oct 10, 2023
Merged

upgrade CRoaring to v2.0.2 #1

merged 6 commits into from
Oct 10, 2023

Conversation

smmathews-brandwatch
Copy link
Collaborator

@smmathews-brandwatch smmathews-brandwatch commented Sep 29, 2023

Upgrade to the latest version of CRoaring. As @acmcmurray points out, there are lots of bug fixes and general improvements.

In order to do this, three changes were necessary:

  1. roaring.c and roaring.h were copied from https://github.com/RoaringBitmap/CRoaring/releases/tag/v2.0.2, without any changes.
  2. The latest cstandard (c17) was set, which allows croaring to determine the atomic implementation.
  3. Minor changes to the type/type-code were fixed up.
  4. The old memory allocation code was changed to use croaring's memory hook system.

@acmcmurray
Copy link
Collaborator

I think this is definitely worth doing, the current version is from 2020 😮 -
I had a skim through, and there's lots of memory leak fixes, bug fixes and general improvements
RoaringBitmap/CRoaring@v0.2.66...v2.0.2 (if anyone else is interested)

@smmathews-brandwatch smmathews-brandwatch changed the title upgrade to v2.0.2 upgrade CRoaring to v2.0.2 Oct 5, 2023
@smmathews-brandwatch smmathews-brandwatch marked this pull request as ready for review October 8, 2023 17:22
@smmathews-brandwatch smmathews-brandwatch merged commit f00a87c into main Oct 10, 2023
6 checks passed
@smmathews-brandwatch smmathews-brandwatch deleted the NT-V2_0_2 branch October 10, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants