Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: update ip package for CVE-2023-42282 #30

Merged
merged 1 commit into from
Feb 19, 2024
Merged

security: update ip package for CVE-2023-42282 #30

merged 1 commit into from
Feb 19, 2024

Conversation

andrewru
Copy link
Contributor

This CVE affects the ip module that this library uses.

Because we use isPrivate I think we aren't fully vulnerable to this in the library but it seems like a safe fix and the tests pass.

Jafferwaffer
Jafferwaffer approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@Jafferwaffer Jafferwaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant seem to find what the breaking change was

@andrewru
Copy link
Contributor Author

Covered with @Jafferwaffer in standup but the change is from new Buffer to buffer.alloc. That's a security update anyway (new Buffer is insecure) and I'll do a major release of this library too.

@andrewru andrewru merged commit 00b53d6 into master Feb 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jafferwaffer Jafferwaffer Jafferwaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewru @Jafferwaffer