Ability to facet on a function #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timatbw
commented
May 18, 2018
| @@ -103,42 +103,7 @@ public Object getMergedResult() { | |||
|
|
|||
| sortBuckets(); | |||
|
|
|||
| long first = freq.offset; | |||
There was a problem hiding this comment.
This block of code has just been moved elsewhere
timatbw
commented
May 18, 2018
| // sort : 'mystat desc' | ||
| // OR | ||
| // sort : { mystat : 'desc' } | ||
| protected void parseSort(FacetRequestSorted sortedFacet, Object sort) { |
There was a problem hiding this comment.
This has just been moved from further down
timatbw
force-pushed
the
function-facet-v7
branch
from
7014c90
to
14ce9d9
Compare
timatbw
force-pushed
the
function-facet-v7
branch
from
14ce9d9
to
53bcea7
Compare
|
Rebased this one to 7.4 now. It can be tested with e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.