Merge pull request #306 from BranchMetrics/rating-average

Field mapping
BranchMetrics · Dec 15, 2017 · 5512d3e · 5512d3e
2 parents 9773769 + ded7ad9
commit 5512d3e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/ios/BranchContentMetadata+RNBranch.m b/ios/BranchContentMetadata+RNBranch.m
@@ -28,7 +28,7 @@ @implementation BranchContentMetadata(RNBranch)
           @"productCategory": [RNBranchProperty propertyWithSetterSelector:@selector(setProductCategory:) type:NSString.class],
           @"productVariant": [RNBranchProperty propertyWithSetterSelector:@selector(setProductVariant:) type:NSString.class],
           @"condition": [RNBranchProperty propertyWithSetterSelector:@selector(setCondition:) type:NSString.class],
-          @"ratingAverage": [RNBranchProperty propertyWithSetterSelector:@selector(setRatingAverage:) type:NSNumber.class],
+          @"ratingAverage": [RNBranchProperty propertyWithSetterSelector:@selector(setRatingAverageWithNumber:) type:NSNumber.class],
           @"ratingCount": [RNBranchProperty propertyWithSetterSelector:@selector(setRatingCountWithNumber:) type:NSNumber.class],
           @"ratingMax": [RNBranchProperty propertyWithSetterSelector:@selector(setRatingMaxWithNumber:) type:NSNumber.class],
           @"addressStreet": [RNBranchProperty propertyWithSetterSelector:@selector(setAddressStreet:) type:NSString.class],

diff --git a/ios/RNBranch.m b/ios/RNBranch.m
@@ -393,6 +393,14 @@ - (BranchUniversalObject *)findUniversalObjectWithIdent:(NSString *)ident reject
     }
 
     event.contentItems = buos;
+    if ([eventName isEqualToString:BranchStandardEventViewItem] && params.count == 0) {
+        for (BranchUniversalObject *buo in buos) {
+            if (!buo.locallyIndex) continue;
+            // for now at least, pending possible changes to the native SDK
+            [buo listOnSpotlight];
+        }
+    }
+
     [event logEvent];
     resolve(NSNull.null);
 }

diff --git a/src/branchUniversalObject.js b/src/branchUniversalObject.js
@@ -83,6 +83,9 @@ export default async function createBranchUniversalObject(identifier, options =
     },
     userCompletedAction(event, state = {}) {
       console.info('[Branch] userCompletedAction is deprecated. Please use logEvent or the BranchEvent class instead.')
+      if (event == RNBranch.REGISTER_VIEW_EVENT) {
+        return this.logEvent(BranchEvent.ViewItem, { customData: state })
+      }
       return this._tryFunction(RNBranch.userCompletedActionOnUniversalObject, event, state)
     },
     logEvent(eventName, params = {}) {