[INTENG-21518] Fix for compilation issue on tvOS #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,14 +30,10 @@ FOUNDATION_EXPORT const unsigned char BranchSDKVersionString[]; | |||
|
|
|||
| #import <BranchSDK/BranchDeepLinkingController.h> | |||
|
|
|||
| #if !TARGET_OS_TV | |||
| // tvOS does not support these features | |||
There was a problem hiding this comment.
So we'll just have to manually place a check in each class/function where we don't support tvOS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
INTENG-21518
Summary
Removed a check for tvOS when including certain files in the umbrella header. Since the files themselves contain the tvOS checks, this one appears to be unnecessary and caused Xcode to be unable to locate these files when building an app with the SDK.
Motivation
Fix for clients using tvOS apps.
Type Of Change
Testing Instructions
Compile and run the app to make sure it still builds on different integrations as well.
cc @BranchMetrics/saas-sdk-devs for visibility.