Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary #812

Merged
merged 106 commits into from
May 5, 2024
Merged

Binary #812

merged 106 commits into from
May 5, 2024

Conversation

B-McCusker56
Copy link
Collaborator

end of semester push of our binary puzzle implementation into dev branch

zacharybonagura and others added 30 commits January 30, 2024 16:27
Binary.java complete

binary puzzle files set-up
Implementing the BinaryType file for the grid cell possibilities
Initialized files, wrote puzzle importer
…BinaryView, BinaryCellFactory, BinaryController, BinaryElementView). These files create the grid view of the puzzle and are responsible for the GUI of the puzzle.
Merge pull request #1 from Bram-Hub/binary
…hree Adjacent Ones and Zeros Contradiction rules
Update config file to include Binary
Deleted false config file, began rule implementation, began fixing pu…
B-McCusker56 and others added 28 commits April 5, 2024 15:52
Fixed buggy three adjacent contradiction rule
# Conflicts:
#	src/main/java/edu/rpi/legup/puzzle/binary/rules/SurroundPairDirectRule.java
#	src/main/java/edu/rpi/legup/puzzle/binary/rules/ThreeAdjacentContradictionRule.java
Added final rule images, adjusted naming conventions for rule images,…
added noncode final commit components
Made improvement to rule images
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave the code a quick skim, seems pretty good. Not going to thoroughly test the puzzle since it went through some pretty rigorous testing at during the RCOS presentations. Puzzle seems to be ready for student use.

@charlestian23 charlestian23 merged commit 58eba41 into dev May 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants