-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary #812
Merged
Merged
Binary #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary.java complete binary puzzle files set-up
Implementing the BinaryType file for the grid cell possibilities
…hed most of binary.java functionality
Initialized files, wrote puzzle importer
…BinaryView, BinaryCellFactory, BinaryController, BinaryElementView). These files create the grid view of the puzzle and are responsible for the GUI of the puzzle.
Merge pull request #1 from Bram-Hub/binary
…hree Adjacent Ones and Zeros Contradiction rules
… specified index.
Update config file to include Binary
…zzle board visual
Deleted false config file, began rule implementation, began fixing pu…
Fixed buggy three adjacent contradiction rule
# Conflicts: # src/main/java/edu/rpi/legup/puzzle/binary/rules/SurroundPairDirectRule.java # src/main/java/edu/rpi/legup/puzzle/binary/rules/ThreeAdjacentContradictionRule.java
… updated wiki with new rule images
Added final rule images, adjusted naming conventions for rule images,…
added noncode final commit components
Made improvement to rule images
charlestian23
approved these changes
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave the code a quick skim, seems pretty good. Not going to thoroughly test the puzzle since it went through some pretty rigorous testing at during the RCOS presentations. Puzzle seems to be ready for student use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
end of semester push of our binary puzzle implementation into dev branch