Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 555 bug fix: bizarre Satisfy Number behavior #755

Conversation

charlestian23
Copy link
Collaborator

@charlestian23 charlestian23 commented Mar 12, 2024

Description

Fixes the bizarre Satisfy Number behavior by using Finish with Bulbs Direct Rule to check when there is only 1 case.

Closes #555

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I attempted the same steps Bram did in #555 and verified that the rule does not check out anymore. I also tested using the rule in its intended fashion and it also worked (which should be backed up by the test suite not catching anything).

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 changed the base branch from master to dev March 12, 2024 21:55
@charlestian23 charlestian23 marked this pull request as ready for review March 26, 2024 21:33
@charlestian23 charlestian23 mentioned this pull request Mar 27, 2024
10 tasks
Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current changes are well document and solve the bug

@Chase-Grajeda Chase-Grajeda merged commit e519c8e into Bram-Hub:dev Apr 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bizzarre Satify Number behavior
2 participants