Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fixes #734

Closed
wants to merge 5 commits into from
Closed

Bug Fixes #734

wants to merge 5 commits into from

Conversation

kchiu1
Copy link
Collaborator

@kchiu1 kchiu1 commented Feb 13, 2024

Description

Corrected the functions of Possible Numbers for Cell

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Opened example sudoku puzzles and checked it worked

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

charlestian23 and others added 4 commits January 26, 2024 13:03
@charlestian23 @Chase-Grajeda
Fixed Short Truth Table case rule bug (Bram-Hub#707)
653c816 
* Revert "Bugfix 549 (Bram-Hub#682)"

This reverts commit 5048ee6.

* Case rule test fix (Bram-Hub#705)

Co-authored-by: Chase Grajeda <[email protected]>

* Rapid fix for STT case rules

Case rules broke at some point from legacy code or merge conflict. Provided is a quick fix in CaseRule and CaseRule_Generic

* Revert "Revert "Bugfix 549 (Bram-Hub#682)"" (Bram-Hub#706)

This reverts commit e9fe310.

---------

Co-authored-by: Chase-Grajeda <[email protected]>
Co-authored-by: Chase Grajeda <[email protected]>
@kchiu1
Some Changes
1598cf2 
you don't need 3 different sets for one loop

changed some names and numberings

(not sure if this is for my own fork or the branch or what)
@kchiu1
Bug Fixes
2d607d3 
The colored tiles weren't generating off of number case rule, so I fixed that.

Now correctly generates 9 branches.
@kchiu1
Merge branch 'master' into sudoku
ff41f92
@charlestian23 charlestian23 changed the base branch from master to sudoku February 13, 2024 23:48
@charlestian23
Copy link
Collaborator

Be careful of the base branch you are merging into. Make sure you are not merging into master. I'm assuming the base branch should be sudoku, but if it's not, then change it to whatever it should be.

@kchiu1
Copy link
Collaborator Author

kchiu1 commented Feb 13, 2024

ah sorry

@Chase-Grajeda
Copy link
Collaborator

Please resolve the current conflict with PossibleNumberCaseRule.java

@Chase-Grajeda Chase-Grajeda reopened this Feb 16, 2024
@kchiu1
I'm not sure what to do here
2095987 
I think this is right but we need to make 4 of the same method based on whether its cells or not not sure how we would do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kchiu1 @charlestian23 @Chase-Grajeda