Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Or Elimination, Or Introduction, Not Introduction, and And Introduction Test Cases #689

Merged
merged 64 commits into from
Nov 28, 2023
Merged

Or Elimination, Or Introduction, Not Introduction, and And Introduction Test Cases #689

merged 64 commits into from
Nov 28, 2023

Conversation

charlestian23
Copy link
Collaborator

@charlestian23 charlestian23 commented Nov 10, 2023 •
edited
Loading

Description

Added tests for Or Elimination, Or Introduction, Not Introduction, and And Introduction.

Closes #665, #666, #669

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

All the test cases pass.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

charlestian23 and others added 30 commits October 13, 2023 16:44
@charlestian23
Initial setup
477dcef
@charlestian23
Working initial test
c98c0f6
@charlestian23
Added another test
f037805
@charlestian23
Added more tests
918deb9
@charlestian23
Added another test
228698b
@charlestian23
Added comments, removed useless imports, added 1 more test
79e131d
@charlestian23
Reformatting
c515259
@charlestian23
Removed useless import
38d25fd
@Corppet
Merge branch 'dev' into stt-test-suite
4cb21a0
@charlestian23
Added initial and elimination test
431ceb3
@charlestian23
Merge branch 'stt-test-suite' of https://github.com/charlestian23/LEGUP…
2fbf61e 
… into stt-test-suite
@charlestian23
Comments and spacing
3581867
@charlestian23
Another test
ecb1007
@charlestian23
Updated comments and wrote new test
fe300f4
@charlestian23
Created two new test files
2785289
@charlestian23
Renamed test to be more descriptive
f1f8fc4
@charlestian23
Added another test
9fc175b
@charlestian23
Rewrote test to be more comprehensive
301baeb
@charlestian23
More tests :))))
71f87af
@charlestian23
Fixed test name and file
767d968
@charlestian23
Fixed test
fbdc046
@charlestian23
Fixed broken tests
0c316c9
@charlestian23
Merge branch 'dev' into stt-test-suite
93abdee
@charlestian23
Shouldn't have touched these files
f728447
@charlestian23
Merge branch 'stt-test-suite' of https://github.com/charlestian23/LEGUP…
a6096ad 
… into stt-test-suite
@charlestian23
CHECKSTYLE
11821ce
@charlestian23
Merge branch 'dev' into stt-test-suite
8893406
@charlestian23
Trying to make CheckStyle happy
ca76fe6
@charlestian23
Initial commit for more tests
e1b6aa4
@charlestian23
Finished a test
c6ca5a1
@charlestian23 charlestian23 changed the title Or Elimination Test Cases Or Elimination and Or Introduction Test Cases Nov 14, 2023
@charlestian23 charlestian23 changed the title Or Elimination and Or Introduction Test Cases Or Elimination, Or Introduction, and Not Introduction Test Cases Nov 14, 2023
@charlestian23 charlestian23 changed the title Or Elimination, Or Introduction, and Not Introduction Test Cases Or Elimination, Or Introduction, Not Introduction, and And Introduction Test Cases Nov 17, 2023
Corppet
Corppet approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@Corppet Corppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Code remain up to standard and comments are to the point.

@Corppet Corppet merged commit 9a61745 into Bram-Hub:dev Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corppet Corppet Corppet approved these changes

@Bram28 Bram28 Awaiting requested review from Bram28

Assignees

@Bram28 Bram28

@Corppet Corppet

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlestian23 @Corppet @Bram28