Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite branch #685

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Conversation

pitbull51067
Copy link
Collaborator

Description

I created a new test case and puzzle to check if the rule would work if the cells of the puzzle could actually be lit, meaning that there would be no contradiction. I made this rule because there was no test case where the cell could actually be lit. The test case works and so I think CannotLightACellContradictionRule works!

Closes #581

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

It has three test cases now where it checks different scenarios of the rule.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

pitbull51067 and others added 5 commits October 20, 2023 17:36
…n to check for the BlockInHorizontalPath test case.
…ll confirm this problem next time and will write another test case.
… cells could actually be lit, meaning there would be no contradiction. The test case passed and so I think CannotLightACellContradictionRule works correctly for all cases.
… cells could actually be lit, meaning there would be no contradiction. The test case passed and so I think CannotLightACellContradictionRule works correctly for all cases.
@charlestian23
Copy link
Collaborator

Seems to be a repeat of #674 , which I reverted since that was accidentally merged into master. This is the correct PR, so I'm going to merge it.

@charlestian23 charlestian23 self-requested a review November 9, 2023 16:20
@charlestian23 charlestian23 merged commit d749c84 into Bram-Hub:dev Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants