Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomic Direct Rule Test #651

Merged
merged 9 commits into from
Oct 17, 2023
Merged

Atomic Direct Rule Test #651

merged 9 commits into from
Oct 17, 2023

Conversation

charlestian23
Copy link
Collaborator

@charlestian23 charlestian23 commented Oct 13, 2023 •
edited
Loading

Description

Added tests for Atomic Direct Rule.

Closes #671

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 changed the title Short Truth Table test suite Atomic Direct Rule Test Oct 13, 2023
@charlestian23 charlestian23 marked this pull request as ready for review October 13, 2023 21:37
@charlestian23 charlestian23 requested a review from Corppet October 13, 2023 21:40
Corppet
Corppet reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@Corppet Corppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. JavaDoc comments are brief and demonstrate how each unit test is used.

@Corppet Corppet merged commit 6986a3d into Bram-Hub:dev Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corppet Corppet Corppet approved these changes

Assignees

@Corppet Corppet

Labels
None yet
Projects
Short Truth Table Test Suite Overhaul
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlestian23 @Corppet