Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added EmptyFieldTest #637

Merged
merged 8 commits into from
Oct 27, 2023
Merged

added EmptyFieldTest #637

merged 8 commits into from
Oct 27, 2023

Conversation

Kevin-771
Copy link
Collaborator

@Kevin-771 Kevin-771 commented Oct 10, 2023 •
edited
Loading

Description

added tests to EmptyFieldTest
added comments to tests in EmptyFieldTest

Closes #602

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kevin-771
EmptyFieldTest
cf72a81 
added test to EmptyFieldTest
added comments to tests in EmptyFieldTest
@Kevin-771 Kevin-771 marked this pull request as ready for review October 10, 2023 21:41
@jac-oblong jac-oblong self-assigned this Oct 20, 2023
jac-oblong
jac-oblong approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@jac-oblong jac-oblong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@jac-oblong jac-oblong merged commit 14ef71c into Bram-Hub:dev Oct 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jac-oblong jac-oblong jac-oblong approved these changes

Assignees

@jac-oblong jac-oblong

Labels
test tree tent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kevin-771 @jac-oblong