Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for LightUp and TreeTent Puzzle Creators #530

Closed
wants to merge 14 commits into from

Conversation

rspacerr
Copy link
Collaborator

@rspacerr rspacerr commented Apr 8, 2023

Description

This should fix both the LightUp and TreeTent puzzle creators, with functionality to place objects in the creator, save the puzzle and load it in the puzzle editor.

Closes #372 and #503

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I opened LightUp and TreeTent independently in the puzzle creator, placed objects, and saved the file, which loaded in the puzzle editor. Fair warning, I was unable to test in the new gradle version since for some reason my build errors out which I am trying to fix. Warning 2, I found that closing the file using ctrl-q from the puzzle editor and loading into the puzzle creator causes a bug, which I think is a native error since this happens for Nurikabe too. I can make an issue after I fix my gradle.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@Corppet Corppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the files you are changing in this pull request. There are a lot of redundant changes that need to be addressed before I can approve/review anything here.

@rspacerr rspacerr requested a review from Corppet April 21, 2023 18:32
Copy link
Collaborator

@Corppet Corppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking a lot better than before, though your changes are causing some tests in TreeTent to fail. Look in the checkstyle check for more details.

@Corppet Corppet marked this pull request as draft April 21, 2023 20:46
@charlestian23
Copy link
Collaborator

I seem to have fixed those issues Ivan mentioned in a separate pull request (#542). Seems like updating from dev didn't bring those changes over?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not have Nurikabe IDs and images be used for Light Up puzzles. You should make a brand new ID and image for the Light Up unknown tile.

@hansongu123
Copy link
Collaborator

what's the status of this PR?

@Corppet
Copy link
Collaborator

Corppet commented Sep 29, 2023

This PR is still a work in progress as not all the checks are successful. If you would like to contribute to this PR you can checkout the branch and try building the project locally to see the errors.

@jac-oblong jac-oblong self-assigned this Nov 10, 2023
@jac-oblong jac-oblong mentioned this pull request Nov 17, 2023
10 tasks
@jac-oblong
Copy link
Collaborator

PR replaced by #629 and #692

@jac-oblong jac-oblong closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tree Tent puzzle editor does not work [ENHANCEMENT] Add Support for LightUp in Puzzle Creator
6 participants