-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for LightUp and TreeTent Puzzle Creators #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the files you are changing in this pull request. There are a lot of redundant changes that need to be addressed before I can approve/review anything here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking a lot better than before, though your changes are causing some tests in TreeTent
to fail. Look in the checkstyle
check for more details.
I seem to have fixed those issues Ivan mentioned in a separate pull request (#542). Seems like updating from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not have Nurikabe IDs and images be used for Light Up puzzles. You should make a brand new ID and image for the Light Up unknown tile.
what's the status of this PR? |
This PR is still a work in progress as not all the checks are successful. If you would like to contribute to this PR you can checkout the branch and try building the project locally to see the errors. |
Description
This should fix both the LightUp and TreeTent puzzle creators, with functionality to place objects in the creator, save the puzzle and load it in the puzzle editor.
Closes #372 and #503
Type of change
How Has This Been Tested?
I opened LightUp and TreeTent independently in the puzzle creator, placed objects, and saved the file, which loaded in the puzzle editor. Fair warning, I was unable to test in the new gradle version since for some reason my build errors out which I am trying to fix. Warning 2, I found that closing the file using ctrl-q from the puzzle editor and loading into the puzzle creator causes a bug, which I think is a native error since this happens for Nurikabe too. I can make an issue after I fix my gradle.
Checklist: