Coupling ramp nuinit #163
Merged
Coupling ramp nuinit #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a work-around for a long-standing bug in CouplingRamp. It works by conforming to the expectations of Coupling::nuinit. The proximal cause of the bug was that CouplingRamp had set a label, "nus", that was incompatible with the label, "nu", that was expected by Coupling::nuinit -- which CouplingRamp inherits. However, ultimately, the difficulty identifying the source of the bug was unexpected behaviour of Configf::find(), for which a new issues has been added: BrainDynamicsUSYD#160.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#101
This pull request addresses the erroneous differences between
CouplingMapandRampwhenRampwas set such that it should produce identical results toMap.All examples provided in the comments to issue #101 now give consistent results.
The key functional change was a single character, from
configf.next("nus");toconfigf.next("nu");, incoupling_ramp.cpp.NOTE: the difficulty identifying the source of the bug was unexpected behaviour of Configf::find(), for which a new issue has been added: #160.