Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity_id attribute #280

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Add entity_id attribute #280

merged 4 commits into from
Aug 3, 2023

Conversation

BradyAJohnston
Copy link
Owner

Adds the attribute entity_id when downloading from the PDB via the PDB code.

Additionally adds a color and selection node based on the entity_id field.

Fixes #265 #266

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 59.42% and project coverage change: +0.05% 🎉

Comparison is base (6b6ec46) 60.56% compared to head (7b850a0) 60.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   60.56%   60.61%   +0.05%     
==========================================
  Files          19       19              
  Lines        2206     2260      +54     
==========================================
+ Hits         1336     1370      +34     
- Misses        870      890      +20     
Files Changed Coverage Δ
MolecularNodes/density.py 23.86% <ø> (+0.26%) ⬆️
MolecularNodes/ui.py 40.18% <30.76%> (-0.82%) ⬇️
MolecularNodes/nodes.py 60.62% <66.66%> (ø)
MolecularNodes/load.py 91.82% <100.00%> (+0.95%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyAJohnston BradyAJohnston marked this pull request as ready for review August 3, 2023 04:01
@BradyAJohnston BradyAJohnston merged commit 3ed5b52 into main Aug 3, 2023
3 of 5 checks passed
@BradyAJohnston BradyAJohnston deleted the dev-att-entity branch August 3, 2023 04:02
BradyAJohnston added a commit that referenced this pull request Sep 14, 2023
BradyAJohnston added a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant