Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the 'add_attribute()` function #279

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Conversation

BradyAJohnston
Copy link
Owner

Improves the adding of attributes to meshes, as well as updating where it is used in star.py. Also adds docstrings to obj.py functions.

@BradyAJohnston BradyAJohnston marked this pull request as ready for review August 2, 2023 06:35
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 90.90% and no project coverage change.

Comparison is base (bcc4c9b) 56.25% compared to head (21c26c3) 56.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   56.25%   56.25%           
=======================================
  Files          15       15           
  Lines        1943     1943           
=======================================
  Hits         1093     1093           
  Misses        850      850           
Files Changed Coverage Δ
MolecularNodes/obj.py 88.00% <86.66%> (+2.28%) ⬆️
MolecularNodes/star.py 68.05% <100.00%> (-1.69%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyAJohnston BradyAJohnston merged commit 98f336c into main Aug 2, 2023
4 of 5 checks passed
@BradyAJohnston BradyAJohnston deleted the dev-add_attribute branch August 2, 2023 07:00
BradyAJohnston added a commit that referenced this pull request Sep 14, 2023
Improves the 'add_attribute()` function
BradyAJohnston added a commit that referenced this pull request Sep 14, 2023
Improves the 'add_attribute()` function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant