Skip to content

Commit

Permalink
[DOC] Update documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
BoubacarDiene committed Dec 31, 2020
1 parent c087d44 commit b3cabb3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ docker run --privileged -it -u $(id -u) --rm -v $(pwd):/workdir networkservice-i

Above runtime options are required to run the service. The configuration file contains commands to execute while the secure mode refers (more or less) to features used when executing commands. Running the service securely means "sanitize files", "drop privileges", "reseed PRNG" before executing commands.

To improve execution time of the service, it might be interesting to test both modes then make your choice depending to your time constraints.
To improve execution time of the service, it might be interesting to test both modes then make your choice depending on your time constraints.

### Development

Expand All @@ -261,7 +261,7 @@ make coverage && make install

**Notes:**
- Make sure to run coverage command after unit tests (```ctest -V``` command) and before [starting the application](#start-the-application)
- The index.html file can then be found at *"out/share/coverage/index.html"*
- The index.html file can then be found at *"out/share/coverage/html/index.html"*

#### Generate dependency graph
```
Expand Down
4 changes: 2 additions & 2 deletions src/utils/command/executor/osal/Linux.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ void Linux::dropPrivileges() const
* granted to the process
*
* Note: The real uid can differ from the effective one when for example
* root changes the owner of the program to itself and set
* "Set-UID" bit (chmod u+s). Thus, the effective uid with be equal to 0 */
* root changes the owner of the program to itself and set "Set-UID"
* bit (chmod u+s). Thus, the effective uid will be equal to 0 */
gid_t realGid = getgid();
gid_t effectiveGid = getegid();
uid_t realUid = getuid();
Expand Down

0 comments on commit b3cabb3

Please sign in to comment.