Skip to content

Commit

Permalink
try to fix sed not finding match
Browse files Browse the repository at this point in the history
  • Loading branch information
@Botspot
Botspot authored Nov 26, 2023
1 parent 7c2e67f commit c851b80
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/updates/Tor.sh
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash


webVer="$(wget -qO- https://sourceforge.net/projects/tor-browser-ports/files | grep -F 'Download Latest Version' --after 1 | tail -n -1 | tr '<>\-_' '\n' | sed -n 8p | sed 's/.tar.xz.*//g')"
webVer="$(wget -qO- https://sourceforge.net/projects/tor-browser-ports/files | grep -F 'Download Latest Version' --after 1 | tail -n -1 | tr '<>\-_' '\n' | sed -n 8p | sed 's/\.tar\.xz.*//g')"
armhf_url="https://sourceforge.net/projects/tor-browser-ports/files/${webVer}/tor-browser-linux-armhf-${webVer}.tar.xz/download"
arm64_url="https://sourceforge.net/projects/tor-browser-ports/files/${webVer}/tor-browser-linux-arm64-${webVer}.tar.xz/download"

Expand Down

4 comments on commit c851b80

@Botspot
Copy link
Owner Author

@Botspot Botspot commented on c851b80 Nov 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theofficialgman, the actions seems to be refusing to run this final sed command, and I'm not sure why. webVer is being set to 13.0.3.tar.xz (106.3 MB), but when I run the same command on my system, it results in the correct 13.0.3 value. Could this be a locale issue or is sed just misbehaving on the github servers?

@theofficialgman
Copy link
Collaborator

@theofficialgman theofficialgman commented on c851b80 Nov 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Botspot I ran the updater BEFORE making the tor commit. So the sed command hasn't been run yet on the GitHub

@Botspot
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then I re-ran the updater AFTER making this commit, which did not seem to change anything. A good followup question is what is necessary to make github see the commit then, if rerunning the action is not enough?

@theofficialgman
Copy link
Collaborator

@theofficialgman theofficialgman commented on c851b80 Nov 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerunning an action runs the action at the same point in the commit history as it was originally run. So if the action was run on commit abc and you rerun it, it will still run on commit abc.

Please sign in to comment.