-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds accept
prop
#18
base: master
Are you sure you want to change the base?
Adds accept
prop
#18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Great thanks. Let me know when you've released a new version! |
I am not the maintainer, so, unfortunately, I can't release a new version. My bad. |
Oh. Fair enough!
…On Mon, 25 Nov 2019 at 11:23, Paolo Di Bello ***@***.***> wrote:
I am not the maintainer, so, unfortunately, I can't release a new version.
My bad.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18?email_source=notifications&email_token=AAT45XUISFVKINFKHH53QPDQVOYTLA5CNFSM4G4J4VZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCB4XY#issuecomment-558112351>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAT45XSI7LD7Q2YBXE743HDQVOYTLANCNFSM4G4J4VZQ>
.
--
Andrew Shankie
+44 (0)7843616844
Proper Design
1 Fox Lane, Cardiff, CF24 1JN
+44 (0) 292000 4234
|
Would you mind reviewing my pull requests too? It looks almost like yours but I added disabled instead. |
The props could be pass directly like this: |
Looks the same as my stuff @PaoloDiBello – just passing additional props to the underlying component. @BosNaufal can we get these little tweaks merged? |
Why not, do you know how? |
No, I'm not sure I'm sorry |
Such a prop would be very useful. @BosNaufal is it planned to merge the changes? |
I need to be able to control which file types the component accepts. I've added a passed-through
accept
prop.