-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#26 #39
Draft
JL-97
wants to merge
8
commits into
Bootstrap-Academy:develop
Choose a base branch
from
JL-97:feature/#26
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/#26 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview deployed to https://5cdce7e2.academy-preview.pages.dev (total size: 11M) |
Hi @JL-97, since the backend is also open source now, would you like to implement this feature yourself? Also, if you are still interested in working on this pull request, there seem to be a few merge conflicts that need to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added a Bookmark Toggle Button to the SkillTreeNodeSvg Component.
It currently only emits an event with the Bookmark state.
And the Components using the SkillTreeNodeSvg Component are currently just printing the state and the affected Skill and Subskill IDs to the Console.
I've tried my Best to create the SVG in Inkscape. I'm by no means a Designer 😅
Maybe this can be used to fully implement the Bookmark Feature.
I guess the next Steps would be:
Type of change
Bootstrap-Academy/Bootstrap-Academy#26
My Bootstrap Academy username:
JL97