Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#26 #39

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Feature/#26 #39

wants to merge 8 commits into from

Conversation

JL-97
Copy link
Contributor

@JL-97 JL-97 commented Oct 9, 2023

Description

I've added a Bookmark Toggle Button to the SkillTreeNodeSvg Component.

It currently only emits an event with the Bookmark state.
And the Components using the SkillTreeNodeSvg Component are currently just printing the state and the affected Skill and Subskill IDs to the Console.

I've tried my Best to create the SVG in Inkscape. I'm by no means a Designer 😅

Maybe this can be used to fully implement the Bookmark Feature.

I guess the next Steps would be:

  • implement the Bookmark Feature in the Backend
  • utilize API from Frontend
  • maybe add Filter to Skilltree to only show bookmarked Skills
  • possibly add dedicated Bookmark Page accessable via the Profile Dropdown Menu
  • or maybe add Bookmarks to Profile Page

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Translation updates (fix/improve or add new translations)

Bootstrap-Academy/Bootstrap-Academy#26

My Bootstrap Academy username:
JL97

@JL-97
Copy link
Contributor Author

JL-97 commented Oct 9, 2023

image

@github-actions
Copy link

Preview deployed to https://5cdce7e2.academy-preview.pages.dev (total size: 11M)

@Defelo
Copy link
Member

Defelo commented Nov 20, 2023

Hi @JL-97, since the backend is also open source now, would you like to implement this feature yourself? Also, if you are still interested in working on this pull request, there seem to be a few merge conflicts that need to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants