Add initial keymap configuration #1304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rokt33r
requested changes
Nov 23, 2021
Rokt33r
reviewed
Nov 29, 2021
src/cloud/components/Application.tsx
Outdated
| @@ -141,7 +140,9 @@ const Application = ({ | |||
|
|
|||
| useEffect(() => { | |||
| const handler = () => { | |||
| setShowFuzzyNavigation((prev) => !prev) | |||
| if (usingElectron) { | |||
There was a problem hiding this comment.
Is there any reason why we blocking this behavior for the browser app?
There was a problem hiding this comment.
Hmm, it had some reason, it was either that it is covered somewhere else, so as not to duplicate it,
or we had it in spec, or I thought it was something else and that web app does not have this search!
(looked at spec, seems it should be BOTH)
I'll investigate more and see if this can be enabled for both and if it is correct to do so.
Komediruzecki
force-pushed
the
feature/add-keymap-customization
branch
2 times, most recently
from
86f47df
to
9eec41c
Compare
Add shortcuts for desktop and web app - Sidenav toggle - Global Search toggle - Preferences toggle Comment out keymaps not implemented
Resolved, What do we want to do with keymaps that aren't really applicable to the web app, should I hide them from UI? Put it like this: What do you think? |
Fix cloud and desktop app global search shortcut - Add desktop app changeable shortcut in menu - Fix cloud having multiple global search shortucts bound
Komediruzecki
force-pushed
the
feature/add-keymap-customization
branch
from
9eec41c
to
574db47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shortcuts for desktop and web app
Comment out keymaps not implemented
Showcase:
Keymaps_2021-11-07.19-00-43.mp4
Issue: https://github.com/Boostnote/BoostHub/issues/1478