Skip to content

Commit

Permalink
trim comments
Browse files Browse the repository at this point in the history
  • Loading branch information
BolunThompson committed Sep 24, 2024
1 parent 497c0b8 commit 343720a
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions kvm_sectorlisp.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ int open_vm(int *kvm, int *vmfd, int *vcpufd) {
// ownership of mem is passed out of the function
int map_mem(const int vmfd, void **mem) {
// map empty memory
// TODO: Is noreserve necessary?
*mem = mmap(NULL, RAM_SIZE, PROT_READ | PROT_WRITE,
MAP_PRIVATE | MAP_ANONYMOUS | MAP_NORESERVE, -1, 0);
if (mem == MAP_FAILED) {
Expand Down Expand Up @@ -183,11 +182,6 @@ static inline bool handle_serial_io(struct kvm_run *run) {
}

int main(void) {
// TODO: Is this the correct formatting? It's a bit dense for my taste.
// TODO: How to properly cite licenses?
// https://lwn.net/Articles/658511/ and https://lwn.net/Articles/658512/
// guided me through the KVM API -- thanks!

signal(SIGINT, handle_sigint);

// Make terminal worse to emulate text-mode VGA
Expand All @@ -210,7 +204,6 @@ int main(void) {
goto cleanup;
// the first ljmp jumps to 0x7c37. The disassembler doesn't list this
// instruction -- it incorrectly disassmebles it as starting at 0x7c36.
// (TODO: Why? Something to do with x86 encoding?)

// on sigint, quit gracefully by setting globar var running
while (running) {
Expand Down

0 comments on commit 343720a

Please sign in to comment.