Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get actual site screenshot #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

get actual site screenshot #170

wants to merge 1 commit into from

Conversation

jamesros161
Copy link
Collaborator

resolves #168

This PR will generate a screenshot of the site just after inspirations installation, to be displayed on the 'My Inspirations' page.

This PR requires the following wpb-assets PR: wpb-assets:#543

Testing instructions:

  1. Install and build this branch of inspirations.
  2. Point to a dev server that utilizes the proper branch of wpb-assets ( 'https://api-dev-jamesros.boldgrid.com' ) will work as of the writing of these instructions
  3. Install an inspiration
  4. Verify the screenshot on the My Inspirations page reflects the installation you chose.

@bwmarkle
Copy link
Contributor

I feel like we're adding more complexity than is needed.

We want to show a screenshot of the theme, it doesn't actually have to be the user's site.

During the Inspirations process, we already have screenshots of the websites. To get the theme's screenshot, we should be able to send over the theme + category?

This approach feels much less complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap out the screenshot of the Crio Starter Content with an actual screenshot of their site
2 participants