now working with the latest update of Rust #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reused icons, both are saved to button_config.json. currently there needs to be a config json so makers can appear properly. (bug: markers appear incorrectly if you try to setup again, must be the offset from the red border) - added "done" button during marker or region selection -added openarrowmarker in region selection dialog -made bobrustpalette receive a screenshot of the color area, split it into 4 by 16 grid and map the coords relative to screen. getSizeButton is changed to work with the brush size limit of 100 -palette generator is unused now. - made the coordinate record in its own file -made circleCache load circle_config.json and create one with defaults if it doesn't exist. made for easier testing. - added config file related functions to ApplicationWindow. Thanks for the developer for explaining and helping me make this work.
Kariaro
reviewed
Sep 16, 2024
|
|
||
| static { | ||
|
|
||
| public static int CIRCLE_0_VALUE = 3; |
Kariaro
reviewed
Sep 16, 2024
| LOGGER.info("Applied paletteRect from loaded configuration: {}", paletteRect); | ||
| } | ||
| screenDrawDialog.setPaletteRect(paletteRect); | ||
| Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize(); |
There was a problem hiding this comment.
This will not work as the screen size is dependent on the current monitor loaded
Kariaro
reviewed
Sep 16, 2024
| private boolean findColorPalette() { | ||
| // Take a screenshot | ||
| BufferedImage screenshot = RustWindowUtil.captureScreenshot(monitor); |
There was a problem hiding this comment.
I'd rather you implement window ui capture screenshot because it's dependant on window scaling. It's complicated when working with multi resolution monitors
Kariaro
reviewed
Sep 16, 2024
| // Change the size | ||
| if (lastSize != blob.sizeIndex) { | ||
| clickSlider(robot, palette.getSizeButton(blob.sizeIndex), 20, autoDelay); | ||
| var paletteSizeButton=palette.getSizeButton(blob.sizeIndex); | ||
| LOGGER.info("point: "+paletteSizeButton.toString()); |
There was a problem hiding this comment.
logging here is excessive, Should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.