Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve remote scanner performance #26

Merged
merged 4 commits into from
Jan 13, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 13, 2024

only store BluetoothServiceInfoBleak as _discovered_device_advertisement_datas can be generated on demand and is now only used for diagnostics

only store BluetoothServiceInfoBleak as _discovered_device_advertisement_datas can
be generated on demand and is now only used for diagnostics
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (788dd77) 49.15% compared to head (8ec047a) 49.53%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/habluetooth/base_scanner.py 78.94% 3 Missing and 1 partial ⚠️
src/habluetooth/scanner.py 66.66% 2 Missing ⚠️
src/habluetooth/wrappers.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   49.15%   49.53%   +0.37%     
==========================================
  Files          12       12              
  Lines         946      959      +13     
  Branches      159      164       +5     
==========================================
+ Hits          465      475      +10     
- Misses        465      467       +2     
- Partials       16       17       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

only store BluetoothServiceInfoBleak as _discovered_device_advertisement_datas can
be generated on demand and is now only used for diagnostics
only store BluetoothServiceInfoBleak as _discovered_device_advertisement_datas can
be generated on demand and is now only used for diagnostics
@bdraco bdraco marked this pull request as ready for review January 13, 2024 23:45
@bdraco bdraco merged commit c549b1c into main Jan 13, 2024
26 of 27 checks passed
@bdraco bdraco deleted the remote_scanner_performance branch January 13, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant