fix: speed up int_to_bluetooth_address C implementation #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to bdraco/ulid-transform#43.
I think the previous implementation also had a memory leak, unless Cython somehow implicitly took care of
free()
ing the mallocatedbdaddr
.Seems to be a 12.5% speed improvement on
test_parse_int_to_bluetooth_address_uncached
on my machine.