Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve performance of gap parser #37

Merged
merged 1 commit into from
Nov 24, 2023
Merged

feat: improve performance of gap parser #37

merged 1 commit into from
Nov 24, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 24, 2023

instead of using a view, use char

before

Parsing 100000 bluetooth messages took 0.032907540997257456 seconds
Parsing 100000 bluetooth messages without caching took 1.9759795420104638 seconds

after

Parsing 100000 bluetooth messages took 0.024532374984119087 seconds
Parsing 100000 bluetooth messages without caching took 1.4332365000154823 seconds

instead of using a view, use char
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a2df27) 100.00% compared to head (c0c6a84) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          211       210    -1     
  Branches        30        30           
=========================================
- Hits           211       210    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 05ea718 into main Nov 24, 2023
19 checks passed
@bdraco bdraco deleted the feat_char branch November 24, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant