Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve performance of processing async_on_raw_advertisements #47

Closed
wants to merge 2 commits into from
Closed

feat: improve performance of processing async_on_raw_advertisements #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5df9ca2
feat: imporve performance of processing async_on_raw_advertisements
bdraco Dec 22, 2024
d47e15f
chore: try another way
bdraco Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/bleak_esphome/backend/scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,18 @@ def async_on_raw_advertisements(
) -> None:
"""Call the registered callback."""
now = MONOTONIC_TIME()
for adv in raw.advertisements:
# Avoid enumeration of raw.advertisements in the loop
# because protobuf will always have an internal exception
# when the list is exhausted.
adv_len_idx = len(raw.advertisements) - 1
for i, adv in enumerate(raw.advertisements):
self._async_on_advertisement(
int_to_bluetooth_address(adv.address),
adv.rssi,
*parse_advertisement_data_tuple((adv.data,)),
{"address_type": adv.address_type},
now,
)
if i == adv_len_idx:
# Break at the end since we are done
break
Loading