Break circular dependencies #4783
Conversation
|
|
||
| trait FetchResource { | ||
|
|
||
| def latest(ref: ResourceRef, project: ProjectRef): FetchF[Resource] |
There was a problem hiding this comment.
Here it is not only the latest but possibly a revision or a tag too
|
|
||
| def apply(xas: Transactors): FetchResource = (ref: ResourceRef, project: ProjectRef) => | ||
| ScopedStateGet | ||
| .latest(Resources.entityType, project, ref.iri) |
There was a problem hiding this comment.
Depending on the case you may want to resolve any type of resource or a specific one.
There was a problem hiding this comment.
Does this imply we should have a function in ScopedStateGet that allows fetching the state without specifying the entity type?
There was a problem hiding this comment.
So far, we have to focus on the one related to resources/schemas, the general one is only used for resolver endpoints afaik so we should just leave it as it is for now as we don't need it for the batch
| import doobie.implicits._ | ||
| import doobie.{Get, Put} | ||
|
|
||
| trait FetchResource { |
There was a problem hiding this comment.
You could declare it in the distage module and use directly where it is used instead of passing along the transactors which is a bit low level ?
Any blocker to that ?
There was a problem hiding this comment.
I think that should be ok yes
| @@ -62,7 +62,7 @@ class ResolverContextResolutionSuite extends NexusSuite { | |||
| ) | |||
| ) | |||
|
|
|||
| def fetchResource: (ResourceRef, ProjectRef) => FetchResource[Resource] = { (r: ResourceRef, p: ProjectRef) => | |||
| def fetchResource: (ResourceRef, ProjectRef) => FetchF[Resource] = { (r: ResourceRef, p: ProjectRef) => | |||
There was a problem hiding this comment.
In the tests, you could have the FetchResource type too
| .query[S] | ||
| .option | ||
|
|
||
| def apply[Id: Put, S: Get](tpe: EntityType, project: ProjectRef, id: Id, rev: Int): ConnectionIO[Option[S]] = |
There was a problem hiding this comment.
We don't store the state for every revision, we have to query for events and replay them in a Stream (the code is already in ScopedStateStore, it could be moved here)
No description provided.