Fix Elasticsearch default views resetter #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| views.compile.toList | ||
| .flatMap { _.traverse { resetView } } | ||
| .flatMap { _ => logger.info("Completed resetting default elasticsearch views.") } | ||
| deleteDatabaseEntries >> |
There was a problem hiding this comment.
So was the fact that ES indices were deleted before the entries also an issue?
There was a problem hiding this comment.
I think it is a combination of that and the fact that we were reading from replicas when recreating the views yes.
Reducing the number of transactions is not a bad thing anyway, it will also help the WAL to get replicated.
olivergrabinski
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4727