-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fitting and optimization steps #75
Conversation
if a mother region count is given as certain, children regions can be given as uncertain. This can happen when literature provides certain counts in mother region (e.g., Striatum is purely inhibitory).
Update docs
For some reason, the tests for the mtype step are now failing: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage ? 97.72%
=======================================
Files ? 22
Lines ? 1451
Branches ? 0
=======================================
Hits ? 1418
Misses ? 33
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I fixed that in #76 |
Code looks good, I have to assume it's correct from the scientific standpoint. Reportedly, this has been used for the latest atlas release in staging (https://bbpteam.epfl.ch/project/issues/browse/BBPP134-1342?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=239469#comment-239469) |
This pull request fixes 3 different issues in the fitting and inhibitory optimization steps: