Faster _compute_region_cell_counts #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some timings:
old: 391s
new: 7.77 s ± 26.5 ms per loop
So about 55 times faster
maxium difference in cell_count: 9.313225746154785e-10
Note: `ValueToIndexVoxels` will at some point be included in voxcell
Code used for testing:
```
from atlas_densities.densities.inhibitory_neuron_densities_optimization import _compute_region_cell_counts
import voxcell
from atlas_densities.densities import utils
annotation = voxcell.VoxelData.load_nrrd('input-data/annotation_ccfv2_l23split_barrelsplit_validated.nrrd')
density = voxcell.VoxelData.load_nrrd('input-data/neuron_density.nrrd')
voxel_volume = annotation.voxel_volume / 1e9
rm =voxcell.RegionMap.load_json('input-data/hierarchy_ccfv2_l23split_barrelsplit.json')
hierarchy_info = utils.get_hierarchy_info(rm, root='root')
res = _compute_region_cell_counts(annotation.raw, density.raw, voxel_volume, hierarchy_info,)
```
mgeplf
force-pushed
the
faster-_compute_region_cell_counts
branch
from
7affcf8 to
7bbb615
Compare
atlas_densities/densities/inhibitory_neuron_densities_optimization.py
Outdated
Show resolved
Hide resolved
atlas_densities/densities/inhibitory_neuron_densities_optimization.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage ? 97.72%
=======================================
Files ? 22
Lines ? 1451
Branches ? 0
=======================================
Hits ? 1418
Misses ? 33
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some timings:
old: 391s
new: 7.77 s ± 26.5 ms per loop
So about 55 times faster
maxium difference in cell_count: 9.313225746154785e-10
Note:
ValueToIndexVoxelswill at some point be included in voxcellCode used for testing: