Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #71

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Cleanup #71

merged 4 commits into from
Mar 22, 2024

Conversation

mgeplf
Copy link
Collaborator

@mgeplf mgeplf commented Mar 1, 2024

  • rename descendant_id_set -> descendant_ids
  • move functions from inhibitory_neuron_densities_helper.py that are only used in inhibitory_neuron_densities_optimization.py to that file

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c2ad129). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage        ?   97.71%           
=======================================
  Files           ?       22           
  Lines           ?     1446           
  Branches        ?        0           
=======================================
  Hits            ?     1413           
  Misses          ?       33           
  Partials        ?        0           
Flag Coverage Δ
pytest 97.71% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mgeplf added 3 commits March 21, 2024 16:27
* move functions from `helper` that were only used in `inhibitory_neuron_densities_optimization`
* removed unused `with_descendants` argument from `_compute_region_cell_counts`
* made `compute_region_volumes` faster
start _check_descendants_consistency simplification
@mgeplf mgeplf requested a review from eleftherioszisis March 22, 2024 08:22
@mgeplf mgeplf merged commit 2b89cfd into main Mar 22, 2024
5 checks passed
@mgeplf mgeplf deleted the cleanup branch March 22, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants