Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the "root" name #50

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Allow specifying the "root" name #50

merged 3 commits into from
Sep 29, 2023

Conversation

mgeplf
Copy link
Collaborator

@mgeplf mgeplf commented Sep 29, 2023

For the cell-densities cell-density and cell-densities inhibitory_and_excitatory_neuron_densities commands. It defaults to "root", like for the AIBS hierarchy, if not specified.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@b1a58cc). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage        ?   97.77%           
=======================================
  Files           ?       22           
  Lines           ?     1391           
  Branches        ?        0           
=======================================
  Hits            ?     1360           
  Misses          ?       31           
  Partials        ?        0           
Flag Coverage Δ
pytest 97.77% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgeplf
Copy link
Collaborator Author

mgeplf commented Sep 29, 2023

I reran cell-density, glia-cell-density and inhibitory-neuron-densities using the pre-commit code, and this code, with the stock AIBS hierarchy. The densities matched for:

    'cell_density.nrrd',

    'astrocyte_density.nrrd',
    'glia_density.nrrd',
    'microglia_density.nrrd',
    'neuron_density.nrrd',
    'oligodendrocyte_density.nrrd',

    'gad67+_density.nrrd',
    'pv+_density.nrrd',
    'sst+_density.nrrd',
    'vip+_density.nrrd',

I then changed the hierarchy root name to "asdf" (and the first_estimates.csv), and reran it; and the above outputted densities were the same.

@mgeplf mgeplf requested a review from jdcourcol September 29, 2023 07:11
@mgeplf mgeplf merged commit 2401266 into main Sep 29, 2023
5 checks passed
@mgeplf mgeplf deleted the root-name branch September 29, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants