Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split probability_map.csv into isocortex layers #49

Closed
wants to merge 1 commit into from

Conversation

mgeplf
Copy link
Collaborator

@mgeplf mgeplf commented Sep 13, 2023

  • instead of using probability_map.csv, one can create the nrrd files split by layer:

atlas-densities mtype-densities create-from-probability-map
--synapse-class INH
--hierarchy-path=../data/1.json
--annotation-path=../data/ccfv2/annotation_25.nrrd
--probability-map $BASE/L1_probability_map.csv
--probability-map $BASE/L23_probability_map.csv
--probability-map $BASE/L4_probability_map.csv
--probability-map $BASE/L5_probability_map.csv
--probability-map $BASE/L6_probability_map.csv
--marker gad67 $MOL/gad67.nrrd
--marker pv $MOL/pv.nrrd
--marker sst $MOL/sst.nrrd
--marker vip $MOL/vip.nrrd
--marker approx_lamp5 $MOL/approx_lamp5.nrrd
--output-dir=output

* instead of using probability_map.csv, one can create the nrrd files
split by layer:

atlas-densities mtype-densities create-from-probability-map  \
    --synapse-class INH                                      \
    --hierarchy-path=../data/1.json                          \
    --annotation-path=../data/ccfv2/annotation_25.nrrd       \
    --probability-map $BASE/L1_probability_map.csv           \
    --probability-map $BASE/L23_probability_map.csv          \
    --probability-map $BASE/L4_probability_map.csv           \
    --probability-map $BASE/L5_probability_map.csv           \
    --probability-map $BASE/L6_probability_map.csv           \
    --marker gad67 $MOL/gad67.nrrd                           \
    --marker pv $MOL/pv.nrrd                                 \
    --marker sst $MOL/sst.nrrd                               \
    --marker vip $MOL/vip.nrrd                               \
    --marker approx_lamp5 $MOL/approx_lamp5.nrrd             \
    --output-dir=output
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@b1a58cc). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage        ?   97.76%           
=======================================
  Files           ?       22           
  Lines           ?     1385           
  Branches        ?        0           
=======================================
  Hits            ?     1354           
  Misses          ?       31           
  Partials        ?        0           
Flag Coverage Δ
pytest 97.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lecriste lecriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce all the 225 inhibitory ME-type densities as in the previous version of the single probability map file.
The main README should be updated accordingly.

@mgeplf
Copy link
Collaborator Author

mgeplf commented Jan 3, 2024

This was meant to show that the split layers probabilities worked; not to be merged - closing.

@mgeplf mgeplf closed this Jan 3, 2024
@mgeplf mgeplf deleted the split-layer-config branch January 3, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants