Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaf region will only trigger if the region exists #48

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cveraszto
Copy link
Collaborator

This is a more generic solution to what was tested by Leo.
The issue with the same conditions will only trigger if the region actually exist.

Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are a result of:
pandas-dev/pandas#54954
So that will be fixed once the new version of pandas is released.

However, the following test is failing, and it should be looked at, I think:

def test_error_on_sigmas_inconsistencies():

@mgeplf
Copy link
Collaborator

mgeplf commented Sep 14, 2023

@cveraszto I have fixed the linting errors and such, but I will need you to update the test so that it makes sense for the changes that were made:
https://github.com/BlueBrain/atlas-densities/actions/runs/6183250760/job/16784618215?pr=48#step:5:61

@cveraszto
Copy link
Collaborator Author

@cveraszto I have fixed the linting errors and such, but I will need you to update the test so that it makes sense for the changes that were made: https://github.com/BlueBrain/atlas-densities/actions/runs/6183250760/job/16784618215?pr=48#step:5:61

Ah, this is important! I will get to this! We can't have 0 values for deltas because that would mean the x_result can't be optimised, as there is no room for standard deviation around a cell count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants