Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed port number from int to string. #33

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Changed port number from int to string. #33

merged 6 commits into from
Nov 8, 2023

Conversation

gabryelreyes
Copy link
Collaborator

@gabryelreyes gabryelreyes commented Nov 7, 2023

Comes from command line as string.
Needed in Winsock as string.
Some formatting changes come from auto-format

Refactored the program arguments to match changes in BlueAndi/DroidControlShip#32

Comes from command line as string.
Needed in Winsock as string.
Some formatting changes come from auto-format
@gabryelreyes gabryelreyes added bug Something isn't working enhancement New feature or request labels Nov 7, 2023
@gabryelreyes gabryelreyes requested a review from BlueAndi November 7, 2023 16:05
@gabryelreyes gabryelreyes self-assigned this Nov 7, 2023
gabryelreyes and others added 3 commits November 8, 2023 14:25
Added verbose option.
Default values are defined and displayed on help text.
Organized comments.
handleCommandLineArguments not define in Test environment
lib/ArduinoNative/Arduino.cpp Outdated Show resolved Hide resolved
lib/ArduinoNative/Arduino.cpp Outdated Show resolved Hide resolved
@gabryelreyes gabryelreyes requested a review from BlueAndi November 8, 2023 20:22
lib/ArduinoNative/Arduino.cpp Outdated Show resolved Hide resolved
@gabryelreyes gabryelreyes requested a review from BlueAndi November 8, 2023 20:41
@BlueAndi BlueAndi merged commit 5565d2e into main Nov 8, 2023
30 checks passed
@gabryelreyes gabryelreyes deleted the portAsString branch November 14, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants